Pin pre-commit to py3.11 #1121
Closed
Pin pre-commit to py3.11 #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some dependencies (namely autoflake) are not compatible with py3.12 yet. Pinning pre-commit to py3.11 until we can move to py3.12. There is no reason for having a pre-commit on a later version than what orion supports anyway.
6 tasks
|
You may want to consider moving from flake to ruff, which has become hugely popular. It has very friendly maintainers, does almost everything flake does, is faster, and easier to configure. It also uses the exact same noqa commands, so it should be a drop in replacement. |
|
@NeilGirdhar Thanks for sharing, I created another PR based on my fork's branch: #1124 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some dependencies (namely autoflake) are not compatible with py3.12 yet.
Pinning pre-commit to py3.11 until we can move to py3.12. There is no reason for having a pre-commit on a later version than what orion supports anyway.