Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#21 [CompetitorPrice] add: filter on columns and modify order of the columns #28

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

evarisk-charles
Copy link
Contributor

No description provided.

@evarisk-charles evarisk-charles self-assigned this Aug 26, 2024
@evarisk-charles evarisk-charles added 1 Estimated resolution time - 30 mins Enhancement New feature or request labels Aug 26, 2024
@evarisk-charles evarisk-charles linked an issue Aug 26, 2024 that may be closed by this pull request
2 tasks
Copy link
Member

@evarisk-micka evarisk-micka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

il manque les filtres mais sinon c cool

@@ -438,8 +438,8 @@
print getTitleFieldOfList($arrayfields[$key]['label'], 0, $_SERVER['PHP_SELF'], 't.' . $key, '', $param, ($cssforfield ? 'class="' . $cssforfield . '"' : ''), $sortfield, $sortorder, ($cssforfield ? $cssforfield . ' ' : '')) . "\n";
}
}
print getTitleFieldOfList('', 0, $_SERVER['PHP_SELF'], '', '', $param, ($cssforfield ? 'class="' . $cssforfield . '"' : ''), $sortfield, $sortorder, ($cssforfield ? $cssforfield . ' ' : '')) . "\n";
print '</tr>';
print getTitleFieldOfList($selectedfields, 0, $_SERVER['PHP_SELF'], '', '', '', '', $sortfield, $sortorder, 'center maxwidthsearch ') . "\n";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pourquoi on pert autant de paramètres

Comment on lines 114 to 117
'label' => ['type' => 'varchar(255)', 'label' => 'Label', 'enabled' => '1', 'position' => 70, 'notnull' => 0, 'visible' => 1, 'searchall' => 1, 'css' => 'minwidth200'],
'competitor_date' => ['type' => 'datetime', 'label' => 'CompetitorDate', 'enabled' => '1', 'position' => 70, 'notnull' => 1, 'visible' => 1],
'amount_ht' => ['type' => 'price', 'label' => 'CompetitorPriceHT', 'enabled' => '1', 'position' => 80, 'notnull' => 0, 'visible' => 1, 'default' => 'null', 'isameasure' => '1'],
'amount_ttc' => ['type' => 'price', 'label' => 'CompetitorPriceTTC', 'enabled' => '1', 'position' => 90, 'notnull' => 0, 'visible' => 1, 'default' => 'null', 'isameasure' => '1'],
'vat' => ['type' => 'varchar(10)', 'label' => 'VAT', 'enabled' => '1', 'position' => 100, 'notnull' => 0, 'visible' => 0],
'url_competitor' => ['type' => 'url', 'label' => 'URLCompetitor', 'enabled' => '1', 'position' => 110, 'notnull' => 0, 'visible' => 1, 'cssview' => 'wordbreak'],
'competitor_date' => ['type' => 'datetime', 'label' => 'CompetitorDate', 'enabled' => '1', 'position' => 120, 'notnull' => 1, 'visible' => 1],
'url_competitor' => ['type' => 'url', 'label' => 'URLCompetitor', 'enabled' => '1', 'position' => 100, 'notnull' => 0, 'visible' => 1, 'cssview' => 'wordbreak'],
'label' => ['type' => 'varchar(255)', 'label' => 'Label', 'enabled' => '1', 'position' => 110, 'notnull' => 0, 'visible' => 1, 'searchall' => 1, 'css' => 'minwidth200'],
'vat' => ['type' => 'varchar(10)', 'label' => 'VAT', 'enabled' => '1', 'position' => 120, 'notnull' => 0, 'visible' => 0],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si l'objectif c'est un order il faut faire varier la position cohérente sql

@nicolas-eoxia nicolas-eoxia merged commit f84ba18 into Eoxia:develop Aug 28, 2024
@evarisk-charles evarisk-charles deleted the fix_field_order branch September 9, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 Estimated resolution time - 30 mins Enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Modification de l'ordre des prix concurrents
3 participants