-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update enzyme-ci.yml #84
Conversation
We don't need to build LLD (takes 2.5 min), we just want to use some LLD for linking. We also don't need llvm plugins.
Co-authored-by: Jed Brown <jed@jedbrown.org>
or will it be --enable-use-lld? stay tuned.
authored-by: @jedbrown
Co-authored-by: Tim Gymnich <tim@gymni.ch>
@wsmoses Just trying to fix our CI with @I-Al-Istannen and Jed, could you please try again adding LLD when you have some free cycles (your last commit failed)? Building LLD + LLD wrapper takes up to 8 minutes, which is up to half the CI time if there isn't much else to be rebuild. |
@wsmoses can you please look again at this? 30 min compile times on every PR are unfortunate. |
@tgymnich Do you have credentials to help with setting up lld here? |
@tgymnich should have permissions now, regardless pushed an lld alias, let's see if that makes rust happy. If not, LLD is installed in the commit I made a few weeks ago to this branch, but wasn't being picked up by rust since there isn't an alias from lld-17 to lld. Note that the CI should not install such an alias system-wide as other runners that use the same machine will run into other LLVM issues otherwise. I added a local alias in the script, let's see if that fixes it. If not, presumably you need to tell rust about the different lld. |
It looks like it got further (an earlier task seemed to succeed that had fuse-ld=lld) but this one did not and then err'd. Looks to be inside rust so going to throw it back to you @ZuseZ4 .
|
That is weird though since I assume ld is on the system? Let alone the lld we added. Let me try one more thing |
Thanks, if the system lld now is around and works, I'll experiment a bit more. cc @jedbrown if you have an idea, please feel free to push too |
I don't think the alias can work because that's only in the shell, not even an exported environment variable. Perhaps we could place a I also note the error message refers to
|
Yeah I think that’s what we’ll need to do.
Make some .local/bin in the workspace dir, add to path, then put a symlink
in.
I was hoping you knew a flag to specify it offhand, but if not that should
work
…On Sun, Apr 14, 2024 at 9:54 PM Jed Brown ***@***.***> wrote:
I don't think the alias can work because that's only in the shell, not
even an exported environment variable. Perhaps we could place a ld.lld
symlink in PATH and export it. https://lld.llvm.org/#using-lld
I also note the error message refers to ld, not ld.lld or lld, despite
the fact that -fuse-ld=lld has been passed in that command. I don't know
if that's a misleading error message or if it's actually looking for the
name ld.
= note: collect2: fatal error: cannot find 'ld'
—
Reply to this email directly, view it on GitHub
<#84 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJTUXC5CM2DNU4MWK6FDZTY5NMOXAVCNFSM6AAAAABFPGCMJOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJVGEZDINJWGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Jay! |
We don't need to build LLD (takes 2.5 min), we just want to use some LLD for linking. We also don't need llvm plugins.