Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tt to mem calls #82

Merged
merged 2 commits into from
Mar 29, 2024
Merged

add tt to mem calls #82

merged 2 commits into from
Mar 29, 2024

Conversation

ZuseZ4
Copy link
Member

@ZuseZ4 ZuseZ4 commented Mar 29, 2024

wip, but didn't break anything for me. Let's ask CI

@jedbrown
Copy link

Does anyone understand why the cache is present, but not found?
image

Run actions/cache@v4
  with:
    path: build/build/x86_64-unknown-linux-gnu/llvm
    key: openstack22-llvm-606bc11367b475542bd6228163424ca43b4dbdbc
    enableCrossOsArchive: false
    fail-on-cache-miss: false
    lookup-only: false
    save-always: false
  env:
    CARGO_INCREMENTAL: 0
    CARGO_TERM_COLOR: always
Cache not found for input keys: openstack22-llvm-606bc11367b475542bd6228163424ca43b4dbdbc

@jedbrown
Copy link

Oh, caches have to be made on the same branch or the default branch. So this issue will go away as soon as we get a passing pipeline on master.

The cache action first searches for cache hits for key and the cache version in the branch containing the workflow run. If there is no hit, it searches for restore-keys and the version. If there are still no hits in the current branch, the cache action retries same steps on the default branch.
https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#matching-a-cache-key

@ZuseZ4
Copy link
Member Author

ZuseZ4 commented Mar 29, 2024

@jedbrown Can you test this a bit? It should fix your thing and now also support slices.

@jedbrown
Copy link

Thanks, this is clean for me on two machines. I'll merge to master so we can seed that cache for future PRs.

@jedbrown jedbrown merged commit 5c5de7c into master Mar 29, 2024
9 of 12 checks passed
@ZuseZ4 ZuseZ4 deleted the morett branch March 30, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants