Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for user-defined rules: Take 4 #589

Merged
merged 8 commits into from
Feb 4, 2023
Merged

Add support for user-defined rules: Take 4 #589

merged 8 commits into from
Feb 4, 2023

Conversation

wsmoses
Copy link
Member

@wsmoses wsmoses commented Feb 2, 2023

No description provided.

@wsmoses wsmoses requested a review from vchuravy February 2, 2023 19:59
@vchuravy vchuravy mentioned this pull request Feb 3, 2023
3 tasks
@vchuravy vchuravy changed the title Rules4 Add support for user-defined rules: Take 4 Feb 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2023

Codecov Report

Base: 73.43% // Head: 73.85% // Increases project coverage by +0.42% 🎉

Coverage data is based on head (6a9520e) compared to base (f29cd60).
Patch coverage: 82.73% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #589      +/-   ##
==========================================
+ Coverage   73.43%   73.85%   +0.42%     
==========================================
  Files          17       17              
  Lines        6147     6288     +141     
==========================================
+ Hits         4514     4644     +130     
- Misses       1633     1644      +11     
Impacted Files Coverage Δ
src/Enzyme.jl 84.61% <ø> (-0.10%) ⬇️
src/compiler/reflection.jl 90.32% <ø> (ø)
src/compiler/interpreter.jl 69.44% <67.56%> (-16.02%) ⬇️
src/compiler.jl 74.03% <84.14%> (+0.84%) ⬆️
src/api.jl 63.72% <100.00%> (+1.03%) ⬆️
src/compiler/pmap.jl 76.37% <100.00%> (-1.17%) ⬇️
src/pmap.jl 83.33% <0.00%> (-1.29%) ⬇️
src/typeanalysis.jl 90.00% <0.00%> (-0.91%) ⬇️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

vchuravy and others added 3 commits February 4, 2023 15:12
Co-authored-by: William Moses <wmoses@mit.edu>
Co-authored-by: Valentin Churavy <vchuravy@mit.edu>
test/rules.jl Outdated Show resolved Hide resolved
@vchuravy vchuravy merged commit 1b709f0 into main Feb 4, 2023
@vchuravy vchuravy deleted the rules4 branch February 4, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants