Add defer_within_autodiff to EnzymeInterpreter
#2254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
reviewed
Jan 7, 2025
vchuravy
reviewed
Jan 7, 2025
src/compiler/interpreter.jl
Outdated
| @@ -909,7 +949,7 @@ function abstract_call_known( | |||
|
|
|||
| (; fargs, argtypes) = arginfo | |||
|
|
|||
| if f === Enzyme.within_autodiff | |||
| if !(interp.defer_within_autodiff) && f === Enzyme.within_autodiff | |||
There was a problem hiding this comment.
Why is this necessary? This fundamentally breaks this functionality?
There was a problem hiding this comment.
This is for a Reactant bug: EnzymeAD/Reactant.jl#442 (comment)
Reason being that Reactant uses EnzymeInterpreter as well, while not necessarily doing autodiff.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2254 +/- ##
==========================================
+ Coverage 67.50% 75.35% +7.84%
==========================================
Files 31 56 +25
Lines 12668 16736 +4068
==========================================
+ Hits 8552 12612 +4060
- Misses 4116 4124 +8 ☔ View full report in Codecov by Sentry. |
wsmoses
approved these changes
Jan 15, 2025
|
@vchuravy can you give this a review before merge |
|
Seems fine. |
…_autodiff` to no return true during Reactant compilation. When this flag is true, `interp.handler` is responsible for handling within_autodiff, or to toggle defer_within_autodiff to false somewhere down the call chain.
vchuravy
force-pushed
the
deferred_within_autodiff
branch
from
3e37885 to
9f54068
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with Reactant pr: EnzymeAD/Reactant.jl#490