Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Enzyme convention #22

Merged
merged 3 commits into from
Nov 4, 2020
Merged

Bump Enzyme convention #22

merged 3 commits into from
Nov 4, 2020

Conversation

wsmoses
Copy link
Member

@wsmoses wsmoses commented Nov 3, 2020

This needs to correspond with using a new build of Enzyme proper.

@wsmoses wsmoses requested a review from vchuravy November 3, 2020 22:09
@vchuravy
Copy link
Member

vchuravy commented Nov 3, 2020

I think we need to update the Yggdrasil builds as well?

@wsmoses wsmoses mentioned this pull request Nov 3, 2020
@wsmoses
Copy link
Member Author

wsmoses commented Nov 3, 2020

On it, JuliaPackaging/Yggdrasil#2042

@vchuravy
Copy link
Member

vchuravy commented Nov 3, 2020

Maybe the binary is already following those conventions? Otherwise CI shouldn't pass.

@wsmoses
Copy link
Member Author

wsmoses commented Nov 3, 2020

That's what I'm guessing given #21 but I don't see how that happened

@vchuravy
Copy link
Member

vchuravy commented Nov 3, 2020

Yeah I messed up and pushed an Enzyme_jll without incrementing the patch version https://travis-ci.com/github/wsmoses/Enzyme.jl/jobs/427340400

@vchuravy
Copy link
Member

vchuravy commented Nov 3, 2020

needs JuliaRegistries/General#24115

Project.toml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants