Import needs_primal from Reactant.jl
#2021
Merged
+44
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2021 +/- ##
==========================================
+ Coverage 67.50% 70.49% +2.98%
==========================================
Files 31 42 +11
Lines 12668 15247 +2579
==========================================
+ Hits 8552 10748 +2196
- Misses 4116 4499 +383 ☔ View full report in Codecov by Sentry. |
wsmoses
approved these changes
Oct 29, 2024
wsmoses
reviewed
Oct 29, 2024
wsmoses
reviewed
Oct 29, 2024
| @@ -35,7 +35,7 @@ EnzymeStaticArraysExt = "StaticArrays" | |||
| BFloat16s = "0.2, 0.3, 0.4, 0.5" | |||
| CEnum = "0.4, 0.5" | |||
| ChainRulesCore = "1" | |||
| EnzymeCore = "0.8.4" | |||
There was a problem hiding this comment.
can the compat be set to either 0.8.4 or 0.8.5 ?
There was a problem hiding this comment.
do you mean to support both versions? we can put the ~ specifier in the version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs_primal(Mode)returnstrueif the mode needs to compute the primal.CC @wsmoses