Update DuplicatedNoNeed error message #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmoses
approved these changes
Oct 1, 2024
wsmoses
reviewed
Oct 1, 2024
src/Enzyme.jl
Outdated
| @@ -600,7 +600,7 @@ f(x) = x*x | |||
| if A <: DuplicatedNoNeed || A <: BatchDuplicatedNoNeed | |||
| throw( | |||
| ErrorException( | |||
| "Return activity `DuplicatedNoNeed` is no longer now returning or avoiding the primal is passed in for Forward Mode AD.\nPlease use autodiff(Forward, ...) or autodiff(ForwardWithPrimal, ...)", | |||
| "Return activity `DuplicatedNoNeed` passed in for Forward Mode AD is no longer now returning or avoiding the primal.\nPlease use autodiff(Forward, ...) or autodiff(ForwardWithPrimal, ...)", | |||
There was a problem hiding this comment.
perhaps, passed in as return activity for Forward Mode AD
Vaibhavdixit02
commented
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the error quite confusing, I hope this is correct/better