Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BFloat16 extension and tests #1725

Merged
merged 1 commit into from
Aug 10, 2024
Merged

Conversation

avik-pal
Copy link
Contributor

the tests are still returning zero similar to #1695, but at least this tests if the extension loads correctly. Marked them as broken for now.

fixes #1723

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.30%. Comparing base (02c5855) to head (48e4f0c).

Files Patch % Lines
ext/EnzymeBFloat16sExt.jl 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1725      +/-   ##
==========================================
+ Coverage   67.39%   68.30%   +0.90%     
==========================================
  Files          32       41       +9     
  Lines       12772    13183     +411     
==========================================
+ Hits         8608     9004     +396     
- Misses       4164     4179      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wsmoses wsmoses merged commit 08dd866 into EnzymeAD:main Aug 10, 2024
34 of 54 checks passed
@avik-pal avik-pal deleted the ap/fix_bfloat16 branch August 10, 2024 05:37
@ChrisRackauckas
Copy link
Contributor

I'm getting reports about this causing lots of test and tutorial failures. Is the patch being released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR: LoadError: UndefVarError: BFloat16 not defined
4 participants