correct some formatting, variable names, and math in box example #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
just-walk
commented
Dec 5, 2023
just-walk
commented
- formatting of variables out_now and out_old is corrected
- variable name in_now replaced with state_now
- math equation describing reverse mode dstate_now:
- correct to reflect multiple seeds
- change notation for adjoint to use overline
- formatting of variables out_now and out_old is corrected - variable name in_now replaced with state_now - math equation describing reverse mode dstate_now: - correct to reflect multiple seeds - change notation for adjoint to use overline
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1184 +/- ##
=======================================
Coverage 75.39% 75.39%
=======================================
Files 35 35
Lines 9788 9788
=======================================
Hits 7380 7380
Misses 2408 2408 ☔ View full report in Codecov by Sentry. |
vchuravy
approved these changes
Dec 6, 2023
michel2323
pushed a commit
that referenced
this pull request
Dec 15, 2023
- formatting of variables out_now and out_old is corrected - variable name in_now replaced with state_now - math equation describing reverse mode dstate_now: - correct to reflect multiple seeds - change notation for adjoint to use overline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.