Upgrade amplify to v6 #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmrabian
requested review from
BearHanded,
braxex and
jessabean
as code owners
gmrabian
requested review from
ntsummers1,
britt-mo,
karla-vm,
bangbay-bluetiger and
JonHolman
JonHolman
reviewed
Oct 21, 2024
bangbay-bluetiger
previously approved these changes
Oct 21, 2024
JonHolman
reviewed
Oct 21, 2024
JonHolman
previously approved these changes
Oct 21, 2024
gmrabian
dismissed stale reviews from JonHolman and bangbay-bluetiger
via
6541af5
|
you can still review but we need to figure out the IDM integration before merging |
jessabean
previously approved these changes
Oct 22, 2024
karla-vm
previously approved these changes
Oct 28, 2024
|
Code Climate has analyzed commit 439e9ed and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 93.8% (0.5% change). View more on Code Climate. |
karla-vm
approved these changes
Oct 29, 2024
jessabean
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change upgrades Amplify from v5 to v6
The upgrade work was previously done in CARTS but was reverted due to an issue that has since been resolved by the maintainers.
Work already done in MCR
For more info on the oauth amplify listener in root, see this PR
References:
upgrade guide
Related ticket(s)
CMDCT-4052
How to test
Everything in the app works as expected. A short list of everything:
Pre-review checklist
[ ] I have updated relevant documentation, if necessary