Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws-deps #139886

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Update aws-deps #139886

merged 1 commit into from
Jan 21, 2025

Conversation

ntsummers1
Copy link
Collaborator

Description

Another week, another go of updating all the AWS Deps to the same version!


How to test

./run local
Play around with the app! States should load, data should save, status's should change, and you should still be able to swap users.

Notes

  • AWS-SDK 3.699.0 -> 3.731.1

Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5015 lines exceeds the maximum allowed for the inline comments feature.

Copy link

codeclimate bot commented Jan 21, 2025

Code Climate has analyzed commit f7b87f7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 81.3%.

View more on Code Climate.

@ntsummers1 ntsummers1 mentioned this pull request Jan 21, 2025
4 tasks
@ntsummers1 ntsummers1 added the ready for review Ready for all the reviews! label Jan 21, 2025
@ntsummers1 ntsummers1 marked this pull request as ready for review January 21, 2025 19:17
@ntsummers1 ntsummers1 merged commit 2798ba4 into main Jan 21, 2025
39 of 40 checks passed
@ntsummers1 ntsummers1 deleted the update-amadeps branch January 21, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant