Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress v12 upgrade #139465

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Cypress v12 upgrade #139465

merged 3 commits into from
Sep 25, 2023

Conversation

gmrabian
Copy link
Contributor

@gmrabian gmrabian commented Sep 21, 2023

Description

Cypress is bugging out on our branches and we need to start updating it anyway so taking this as a first step to see if it helps

upgraded to 12.15.1 because of this

Related ticket(s)

MDCT-2806


How to test

Cypress tests pass on this branch, or you can run locally with:
CYPRESS_ADMIN_USER_PASSWORD=pw CYPRESS_STATE_USER_PASSWORD=pw yarn test
replace pw with the cypress test user password

Important updates

yarnage


Author checklist

  • I have performed a self-review of my code
  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary

@gmrabian gmrabian mentioned this pull request Sep 21, 2023
3 tasks
@gmrabian gmrabian marked this pull request as ready for review September 21, 2023 20:43
@gmrabian gmrabian changed the title Cypress upgrade Cypress v12 upgrade Sep 21, 2023
.github/workflows/deploy.yml Show resolved Hide resolved
.github/workflows/deploy.yml Show resolved Hide resolved
.github/workflows/deploy.yml Show resolved Hide resolved
package.json Show resolved Hide resolved
tests/cypress/support/commands.js Show resolved Hide resolved
@gmrabian gmrabian added the ready for review Ready for all the reviews! label Sep 21, 2023
Copy link
Contributor

@benmartin-coforma benmartin-coforma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good work. I've got a comment on a potential low-impact bug - but if it is a bug, it's an existing one.

tests/cypress/cypress.config.js Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Sep 22, 2023

Code Climate has analyzed commit 4ab24f4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 61.3% (0.0% change).

View more on Code Climate.

@gmrabian gmrabian merged commit 101a717 into main Sep 25, 2023
@gmrabian gmrabian deleted the cypress-upgrade branch September 25, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants