EREGCSC-2779 -- Vitest fixes #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…String to citationString
…nstead of comma separated values
|
Closed to free up buckets; will reopen later |
|
✨ See the Django Site in action ✨ |
|
✨ See the Django Site in action ✨ |
cgodwin1
approved these changes
Aug 16, 2024
peggles2
pushed a commit
that referenced
this pull request
Aug 20, 2024
* chore: light begin JSDoc annotations; clean up vestigial get method * chore: update getRegSearchResults to use passed in API url * chore: getSupplementalContent using passed in apiUrl; update locationString to citationString * chore: update getTitles to need apiUrl param * chore: getParts cleanup * chore: clean up statues methods and assoc. JSDoc * chore: cleanup return * chore: fix casing issue; continue to refine JSDoc annotations * chore: continue to update api method params to be objects with keys instead of comma separated values * chore: further work to add consistency to api method param format * chore: continue * chore: update getTitles * chore: further work * chore: finish api.js * chore: finish filters.js * chore: remove synthetic part that is no longer relevant * chore: remove some unused methods, update JSDoc annotations, etc * chore: remove vestigial/unused utility methods * chore: rebuild package-lock to get vitest to work on new machine * test: begin updating/fixing vitest unit tests * test: fix rest of utils unit tests * test: remove snapshot-only tests in results-item-part * test: fix getResultLink tests * test: fix getResultSnippet tests * test: all tests pass * test: ignore msw folder for vitest coverage stats * test: add Vitest UI Make command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves EREGCSC-2779
Description
The V4 refactor broke some front end tests and made some others obsolete. This PR will remove the unneeded tests and fix the remaining broken tests.
This pull request changes:
make test.vitest.uiSteps to manually verify this change:
make test.vitest.ui