Skip to content

Commit

Permalink
EREGCSC-2685 -- Move subject page search box to filter region (#1461)
Browse files Browse the repository at this point in the history
* feat: move search input on subjects page; direct to search page when used

* feat: method to get subject name as input placeholder

* feat: styles; use v-input label instead of placeholder

because placeholder does not allow text-overflow: ellipsis

* style: various style tweaks

* fix: counts based on q on search page and subjects param on subj pg

* test: fix a few failing tests

* chore: remove q param from subjects page logic

* chore: clean up vestigial logic concerning search query labels in subjects pg

* test: linting; begin updating subjects test suite

* test: fix a11y test and a few others

* test: update all subjects test to work without search query

* chore: remove search slot from policysidebar component

* style: tweak subjects page filters mobile styling

* chore: linting

* feat: refactor search input redirect/clear logic in subjects page

* test: clearing subjects input field should not reload page

* chore: tweak back button behavior

* style: tweak subjects page doc type selectors narrow styles
  • Loading branch information
PhilR8 authored Nov 4, 2024
1 parent 646f9bd commit 8b5bd02
Show file tree
Hide file tree
Showing 13 changed files with 262 additions and 281 deletions.
8 changes: 4 additions & 4 deletions solution/ui/e2e/cypress/e2e/search.spec.cy.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ describe("Search flow", () => {
cy.viewport("macbook-15");
cy.visit(`/search`, { timeout: 60000 });
cy.get("input#main-content")
.should("be.visible")
.should("exist")
.type("test search", { force: true });
cy.get('[data-testid="search-form-submit"]').click({
force: true,
Expand All @@ -106,7 +106,7 @@ describe("Search flow", () => {
});

cy.get("input#main-content")
.should("be.visible")
.should("exist")
.type("test", { force: true });

cy.findByDisplayValue("test")
Expand Down Expand Up @@ -148,7 +148,7 @@ describe("Search flow", () => {
});

cy.get("input#main-content")
.should("be.visible")
.should("exist")
.type(`${SEARCH_TERM_2}`, { force: true });
cy.get('[data-testid="search-form-submit"]').click({
force: true,
Expand Down Expand Up @@ -184,7 +184,7 @@ describe("Search flow", () => {
});

cy.get("input#main-content")
.should("be.visible")
.should("exist")
.type(`${SEARCH_TERM}`, { force: true });
cy.get('[data-testid="search-form-submit"]').click({
force: true,
Expand Down
Loading

0 comments on commit 8b5bd02

Please sign in to comment.