Skip to content

Commit

Permalink
EREGCSC-2778 -- Ensure JSDoc info is correct (#1398)
Browse files Browse the repository at this point in the history
* chore: light begin JSDoc annotations; clean up vestigial get method

* chore: update getRegSearchResults to use passed in API url

* chore: getSupplementalContent using passed in apiUrl; update locationString to citationString

* chore: update getTitles to need apiUrl param

* chore: getParts cleanup

* chore: clean up statues methods and assoc. JSDoc

* chore: cleanup return

* chore: fix casing issue; continue to refine JSDoc annotations

* chore: continue to update api method params to be objects with keys instead of comma separated values

* chore: further work to add consistency to api method param format

* chore: continue

* chore: update getTitles

* chore: further work

* chore: finish api.js

* chore: finish filters.js

* chore: remove synthetic part that is no longer relevant

* chore: remove some unused methods, update JSDoc annotations, etc

* chore: remove vestigial/unused utility methods
  • Loading branch information
PhilR8 authored Aug 15, 2024
1 parent cf2a1b4 commit 66738a3
Show file tree
Hide file tree
Showing 26 changed files with 287 additions and 1,610 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,12 @@ export default {
},
created() {
getLastParserSuccessDate(this.apiUrl, { title: 42 })
.then(
(response) => {
this.lastParserSuccess = response;
}
)
getLastParserSuccessDate({ apiUrl: this.apiUrl })
.then((response) => {
this.lastParserSuccess = response;
})
.catch(() => {
this.lastParserSuccess = "N/A";
this.lastParserSuccess = "N/A";
});
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ export default {
if (location) {
response = await getSupplementalContent({
apiUrl: this.apiUrl,
builtLocationString: location,
builtCitationString: location,
pageSize: 1000,
});
}
Expand Down Expand Up @@ -251,12 +251,12 @@ export default {
}
},
async getPartDictionary() {
const sections = await getSubpartTOC(
this.apiUrl,
this.title,
this.part,
this.subparts[0]
);
const sections = await getSubpartTOC({
apiUrl: this.apiUrl,
title: this.title,
part: this.part,
subPart: this.subparts[0],
});
const secList = getSectionsRecursive(sections);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ provide("homeUrl", props.homeUrl);
// Titles
const titles = ref([]);
const getTitlesArray = async () => {
const titlesArray = await getTitles(props.apiUrl);
const titlesArray = await getTitles({ apiUrl: props.apiUrl });
const formattedTitleNamesArray = titlesArray.map(
(title) => `Title ${title}`
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,13 @@ export default {
},
created() {
getGovInfoLinks(this.apiUrl, {
title: this.title,
part: this.part,
section: this.section,
getGovInfoLinks({
apiUrl: this.apiUrl,
filterParams: {
title: this.title,
part: this.part,
section: this.section,
},
})
.then((response) => {
this.govInfoLinks = response.sort((a, b) => b.year - a.year);
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading

0 comments on commit 66738a3

Please sign in to comment.