Build config #8
Merged
Build config #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| err := makeTar(localPath, dest, copyFiles, globExps, tarWriter) | ||
| if err != nil { | ||
| log.Errorf("Error while creating tar: %#v", err) | ||
| os.Exit(1) |
There was a problem hiding this comment.
Did you mean to keep the log & os.Exit here, or should it just be changed to a return errors.Wrap(err, "error while creating tar")
This is also the case in GetTarReader but I can't leave a comment on that bit because it's not changed (the log & os.Exit must have originally been my bad).
pkg/sync/adapter.go
Outdated
| @@ -31,8 +32,8 @@ type Adapter struct { | |||
| common.AdapterContext | |||
| } | |||
|
|
|||
| // SyncFilesBuild sync the local files to build container volume | |||
| func (a Adapter) SyncFilesBuild(buildParameters common.BuildParameters, compInfo common.ComponentInfo) (syncFolder string, err error) { | |||
| // SyncsFilesBuild sync the local files to build container volume | |||
There was a problem hiding this comment.
Should be SyncFilesBuild, this'll throw a warning because of your additional 's'. I don't mean to be picky, but you did say be harsh!
There was a problem hiding this comment.
I thought I change that :(, will update
There was a problem hiding this comment.
I had changed it on my branch that you'd merged, so maybe it changed back during a merge conflict or something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does does this PR do / why we need it:
Add BuildConfig path.