Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete deploy #7

Merged
merged 5 commits into from
Jun 25, 2020
Merged

Delete deploy #7

merged 5 commits into from
Jun 25, 2020

Conversation

EnriqueL8
Copy link
Owner

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind code-refactoring

What does does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer:

@CameronMcWilliam
Copy link

CameronMcWilliam commented Jun 25, 2020 •
edited
Loading

Could not delete deployment nodejs-deploy as deployment was not found should be the second test string output, not "blah"

groeges
groeges approved these changes Jun 25, 2020
View reviewed changes
Copy link

@groeges groeges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EnriqueL8 EnriqueL8 merged commit 12658f2 into deploy_command Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groeges groeges groeges approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EnriqueL8 @CameronMcWilliam @groeges