Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CI and Python dependencies #523

Merged
merged 10 commits into from
Dec 22, 2023

Conversation

AdrianDsg
Copy link
Contributor

fix #498

Hi @EnricoMi,
I just discovered this project.

This PR upgrades the checkout action to release v4. I also used the upgrade-pip-packages.sh script to upgrade the pip dependencies.

I hope that this PR might be helpful. I'd be grateful if you would consider sharing your feedback on this below.

@AdrianDsg
Copy link
Contributor Author

Hi @EnricoMi,
Just a friendly reminder that I'm looking for your feedback on this.

@EnricoMi
Copy link
Owner

Thanks for the contribution.

I tend to upgrade all CI dependencies at once and actions/checkout is not the only one that can be upgraded. If you could also upgrade all other dependencies, that would be grand.

I tend to upgrade the Python dependencies just before a release to avoid keeping upgrading them without releasing, which is some fruitless exercise.

@EnricoMi EnricoMi changed the title upgrade dependencies Upgrade CI dependencies Oct 27, 2023
@github-actions
Copy link

github-actions bot commented Oct 27, 2023

Test Results (reference)

   135 files  ±0     135 suites  ±0   41m 19s ⏱️ -52s
   436 tests ±0     436 ✅ ±0      0 💤 ±0  0 ❌ ±0 
58 860 runs  ±0  57 516 ✅ ±0  1 344 💤 ±0  0 ❌ ±0 

Results for commit bd096ff. ± Comparison against base commit d764099.

♻️ This comment has been updated with latest results.

@EnricoMi EnricoMi changed the title Upgrade CI dependencies Upgrade CI and Python dependencies Dec 19, 2023
@EnricoMi EnricoMi force-pushed the adriandsg/upgrade-dependencies branch 2 times, most recently from a7e22f3 to 6035ef0 Compare December 19, 2023 15:00
@EnricoMi EnricoMi force-pushed the adriandsg/upgrade-dependencies branch from 6035ef0 to 917c6c2 Compare December 19, 2023 15:05
@EnricoMi EnricoMi force-pushed the adriandsg/upgrade-dependencies branch from 917c6c2 to 533062f Compare December 19, 2023 15:17
@EnricoMi
Copy link
Owner

Blocked by flaky download action v4: actions/download-artifact#249

Copy link
Owner

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EnricoMi EnricoMi merged commit bea8616 into EnricoMi:master Dec 22, 2023
53 checks passed
@EnricoMi
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants