Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove venv and pip upgrade from composite action #127

Merged
merged 13 commits into from
May 8, 2021

Conversation

EnricoMi
Copy link
Owner

@EnricoMi EnricoMi commented May 3, 2021

To simplify the composite action and improve startup speed, lets remove using a virtual environment. This action can easily isolated from other actions that use the runner's Python environment by running it in a dedicated workflow. For the discussion, see #123.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@EnricoMi EnricoMi force-pushed the branch-composite-remove-venv branch from 26e9e28 to f499f1b Compare May 3, 2021 11:53
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@EnricoMi EnricoMi force-pushed the branch-composite-remove-venv branch from e9fe4c4 to 32afe65 Compare May 3, 2021 12:47
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented May 6, 2021

Unit Test Results (Linux)

     11 files  ±0       11 suites  ±0   19s ⏱️ ±0s
   224 tests ±0     223 ✔️ ±0    1 💤 ±0  0 ❌ ±0 
2 464 runs  ±0  2 441 ✔️ ±0  23 💤 ±0  0 ❌ ±0 

Results for commit 922b84c. ± Comparison against base commit 922b84c.

♻️ This comment has been updated with latest results.

@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented May 6, 2021

Unit Test Results (Windows)

     11 files  ±0       11 suites  ±0   19s ⏱️ ±0s
   224 tests ±0     223 ✔️ ±0    1 💤 ±0  0 ❌ ±0 
2 464 runs  ±0  2 441 ✔️ ±0  23 💤 ±0  0 ❌ ±0 

Results for commit 922b84c. ± Comparison against base commit 922b84c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 6, 2021

Unit Test Results (Dockerfile)

     11 files  ±0       11 suites  ±0   19s ⏱️ ±0s
   224 tests ±0     223 ✔️ ±0    1 💤 ±0  0 ❌ ±0 
2 464 runs  ±0  2 441 ✔️ ±0  23 💤 ±0  0 ❌ ±0 

Results for commit 922b84c. ± Comparison against base commit 922b84c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 6, 2021

Unit Test Results (Docker Image)

     11 files  ±0       11 suites  ±0   19s ⏱️ ±0s
   224 tests ±0     223 ✔️ ±0    1 💤 ±0  0 ❌ ±0 
2 464 runs  ±0  2 441 ✔️ ±0  23 💤 ±0  0 ❌ ±0 

Results for commit 922b84c. ± Comparison against base commit 922b84c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 6, 2021

Unit Test Results (macOS)

     11 files  ±0       11 suites  ±0   19s ⏱️ ±0s
   224 tests ±0     223 ✔️ ±0    1 💤 ±0  0 ❌ ±0 
2 464 runs  ±0  2 441 ✔️ ±0  23 💤 ±0  0 ❌ ±0 

Results for commit 922b84c. ± Comparison against base commit 922b84c.

♻️ This comment has been updated with latest results.

@EnricoMi EnricoMi force-pushed the branch-composite-remove-venv branch from f4bbc2b to 183f2de Compare May 8, 2021 16:07
@github-actions

This comment has been minimized.

@EnricoMi EnricoMi merged commit 922b84c into master May 8, 2021
@EnricoMi EnricoMi deleted the branch-composite-remove-venv branch May 8, 2021 16:19
@github-actions
Copy link

github-actions bot commented May 8, 2021

Unit Test Results (setup-python)

     11 files  ±0       11 suites  ±0   19s ⏱️ ±0s
   224 tests ±0     223 ✔️ ±0    1 💤 ±0  0 ❌ ±0 
2 464 runs  ±0  2 441 ✔️ ±0  23 💤 ±0  0 ❌ ±0 

Results for commit 922b84c. ± Comparison against base commit 922b84c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants