Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GitHub client retry behaviour #111

Merged
merged 4 commits into from
Apr 11, 2021
Merged

Improve GitHub client retry behaviour #111

merged 4 commits into from
Apr 11, 2021

Conversation

EnricoMi
Copy link
Owner

@EnricoMi EnricoMi commented Apr 11, 2021

Post requests and 5xx errors are not retried. Tests with a mock REST endpoint the retry behaviour of the GitHub client. Fixes #110.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@EnricoMi EnricoMi merged commit ea83136 into master Apr 11, 2021
@EnricoMi EnricoMi deleted the branch-gh-retries branch April 11, 2021 20:33
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link

Unit Test Results (Linux)

     11 files  ±0       11 suites  ±0   29s ⏱️ ±0s
   194 tests ±0     193 ✔️ ±0    1 💤 ±0  0 ❌ ±0 
2 134 runs  ±0  2 111 ✔️ ±0  23 💤 ±0  0 ❌ ±0 

Results for commit ea83136. ± Comparison against base commit ea83136.

@github-actions
Copy link

Unit Test Results (setup-python)

     11 files  ±0       11 suites  ±0   29s ⏱️ ±0s
   194 tests ±0     193 ✔️ ±0    1 💤 ±0  0 ❌ ±0 
2 134 runs  ±0  2 111 ✔️ ±0  23 💤 ±0  0 ❌ ±0 

Results for commit ea83136. ± Comparison against base commit ea83136.

@github-actions
Copy link

Unit Test Results (Dockerfile)

     11 files  ±0       11 suites  ±0   29s ⏱️ ±0s
   194 tests ±0     193 ✔️ ±0    1 💤 ±0  0 ❌ ±0 
2 134 runs  ±0  2 111 ✔️ ±0  23 💤 ±0  0 ❌ ±0 

Results for commit ea83136. ± Comparison against base commit ea83136.

@github-actions
Copy link

Unit Test Results (Docker Image)

     11 files  ±0       11 suites  ±0   29s ⏱️ ±0s
   194 tests ±0     193 ✔️ ±0    1 💤 ±0  0 ❌ ±0 
2 134 runs  ±0  2 111 ✔️ ±0  23 💤 ±0  0 ❌ ±0 

Results for commit ea83136. ± Comparison against base commit ea83136.

@github-actions
Copy link

Unit Test Results (macOS)

     11 files  ±0       11 suites  ±0   29s ⏱️ ±0s
   194 tests ±0     193 ✔️ ±0    1 💤 ±0  0 ❌ ±0 
2 134 runs  ±0  2 111 ✔️ ±0  23 💤 ±0  0 ❌ ±0 

Results for commit ea83136. ± Comparison against base commit ea83136.

@github-actions
Copy link

Unit Test Results (Windows)

     11 files  ±0       11 suites  ±0   29s ⏱️ ±0s
   194 tests ±0     193 ✔️ ±0    1 💤 ±0  0 ❌ ±0 
2 134 runs  ±0  2 111 ✔️ ±0  23 💤 ±0  0 ❌ ±0 

Results for commit ea83136. ± Comparison against base commit ea83136.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random failure with github.GithubException.GithubException: 500 null
1 participant