Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brug testcommon.etl i wholesale#587 #3089

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Brug testcommon.etl i wholesale#587 #3089

wants to merge 12 commits into from

Conversation

JakobStricker
Copy link

Description

Implementation of the testcommon.etl framework into the wholesale repo.
Changes have been done in the databricks/calculation_engine_tests_features folder.

This has been done to optimize the test procedure in the wholesale repo based on the the procedure from the measurement repo.

closes #587

Pull-request quality

  • The title adheres to this guide
  • Tests are written and executed locally
  • Subsystem tests have been tested (by manually deploying to dev_002)

@JakobStricker JakobStricker requested a review from a team as a code owner January 15, 2025 13:04
BjarkeMeier
BjarkeMeier reviewed Jan 15, 2025
View reviewed changes
source/databricks/calculation_engine/tests/features/conftest.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you encounter the tests including "second run"?

BjarkeMeier
BjarkeMeier reviewed Jan 15, 2025
View reviewed changes
source/databricks/calculation_engine/tests/features/conftest.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you updated all tests in energy_calculation and wholesale_calculation? If so, then there should be some stuff we can remove from the utils folder. I can help with that.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2025 •
edited
Loading

Python test results

3 tests   3 ✅  10s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 8db72d6.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BjarkeMeier BjarkeMeier BjarkeMeier left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JakobStricker @BjarkeMeier