Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Remove Settlement Reports from Wholesale #3086

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

feat: Remove Settlement Reports from Wholesale #3086

wants to merge 13 commits into from

Conversation

cenh-halfspace
Copy link
Contributor

@cenh-halfspace cenh-halfspace commented Jan 13, 2025 •
edited
Loading

Description

Removed settlement reports from the Wholesale domain, including subsystem tests. This together with PRs for dh3-environments and dh3-infrastructure combines removing it from wholesale.

Pull-request quality

  • The title adheres to this guide
  • Tests are written and executed locally
  • Subsystem tests have been tested (by manually deploying to dev_002)

@cenh-halfspace cenh-halfspace changed the title Remove Settlement Reports from Wholesale feat: Remove Settlement Reports from Wholesale Jan 14, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

Test results for \source\dotnet\wholesale-api\Orchestrations.IntegrationTests\bin\Release\net8.0\Energinet.DataHub.Wholesale.Orchestrations.IntegrationTests.dll

30 tests   30 ✅  3m 30s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit b2d683a.

♻️ This comment has been updated with latest results.

@cenh-halfspace cenh-halfspace marked this pull request as ready for review January 15, 2025 12:32
@cenh-halfspace cenh-halfspace requested review from a team as code owners January 15, 2025 12:32
BjarkeMeier
BjarkeMeier reviewed Jan 15, 2025
View reviewed changes
.github/actions/add-databricks-release-assets/Add-Assets.Tests.ps1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I search for "settlementreport" (case insensitive) there are still 81 occurrences left. Some of them may be ok, but some also need to be removed.
But perhaps a .NET developer should fix those in another PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolajAaH NicolajAaH NicolajAaH approved these changes

@BjarkeMeier BjarkeMeier BjarkeMeier approved these changes

@MadsDue MadsDue Awaiting requested review from MadsDue MadsDue is a code owner automatically assigned from Energinet-DataHub/team-mosaic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cenh-halfspace @BjarkeMeier @NicolajAaH