Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Segregate app package #2785

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

feat: Segregate app package #2785

wants to merge 11 commits into from

Conversation

BjarkeMeier
Copy link
Contributor

@BjarkeMeier BjarkeMeier commented Sep 15, 2024 •
edited
Loading

Description

TODO:

  • How to avoid developers having to do editable installs when not using PyCharm?
  • How to avoid editable install in each entrypoints.sh invocation?
  • Does logging work when located in app package? See here and here
  • Does the settlement report job work in environments, or must the app package be installed as well somehow?

App package will eventually be moved to opengeh-python-packages.

Pull-request quality

  • The title adheres to this guide
  • Tests are written and executed locally
  • Subsystem tests have been tested (by manually deploying to dev_002)

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 15, 2024 •
edited
Loading

Python test results

19 tests   19 ✅  5s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 4fc7d33.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BjarkeMeier