Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refac: Improve performance of getting actors. #1596

Merged
merged 6 commits into from
Mar 30, 2023

Conversation

defectiveAi
Copy link
Contributor

No description provided.

@nx-cloud
Copy link

nx-cloud bot commented Mar 30, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4b3a659. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@defectiveAi defectiveAi temporarily deployed to AzureAuth March 30, 2023 09:28 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2023

Codecov Report

Merging #1596 (1c2f5fe) into main (32bb190) will increase coverage by 14.86%.
The diff coverage is 28.57%.

@@             Coverage Diff             @@
##             main    #1596       +/-   ##
===========================================
+ Coverage   23.63%   38.49%   +14.86%     
===========================================
  Files          61       76       +15     
  Lines        1451     1839      +388     
  Branches      119        0      -119     
===========================================
+ Hits          343      708      +365     
- Misses       1097     1116       +19     
- Partials       11       15        +4     
Impacted Files Coverage Δ
....WebApi/Controllers/MarketParticipantController.cs 50.00% <16.66%> (-7.34%) ⬇️
...on/Controllers/MarketParticipantControllerTests.cs 100.00% <100.00%> (ø)

... and 20 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@defectiveAi defectiveAi temporarily deployed to AzureAuth March 30, 2023 10:36 — with GitHub Actions Inactive
@defectiveAi defectiveAi temporarily deployed to AzureAuth March 30, 2023 11:15 — with GitHub Actions Inactive
@defectiveAi defectiveAi merged commit 444de22 into main Mar 30, 2023
@defectiveAi defectiveAi deleted the aiu/improve_get_actors_performance branch March 30, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants