Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NX to latest version (15.8.9) #1586

Merged
merged 24 commits into from
Mar 31, 2023
Merged

Update NX to latest version (15.8.9) #1586

merged 24 commits into from
Mar 31, 2023

Conversation

frontend-specialisten
Copy link
Contributor

@frontend-specialisten frontend-specialisten commented Mar 29, 2023 •
edited
Loading

Description

Update NX to latest version (15.8.9)

  • NX migrations has been implemented
  • Some tsconfig.spec.json has now a target of ES2016 due to some issues caused by Material harnesses:
    ex. Expected to be running in 'ProxyZone', but it was not found.

@nx-cloud
Copy link

nx-cloud bot commented Mar 29, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e694f4d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

@cla-bot cla-bot bot added the cla-signed label Mar 29, 2023
@frontend-specialisten frontend-specialisten changed the title Chore/update nx 15 8 Update NX to latest version (15.8.9) Mar 29, 2023
@frontend-specialisten frontend-specialisten marked this pull request as ready for review March 29, 2023 16:31
mimse
mimse previously approved these changes Mar 30, 2023
View reviewed changes
jest.preset.js Show resolved Hide resolved
dzhavat
dzhavat reviewed Mar 30, 2023
View reviewed changes
Copy link
Contributor

@dzhavat dzhavat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: nice that you've managed to upgrade to latest Nx (and Angular) 👌
Have a few questions :)

migrations.json Outdated Show resolved Hide resolved
jest.preset.js Show resolved Hide resolved
libs/ui-watt/tsconfig.spec.json Outdated Show resolved Hide resolved
ManBearTM
ManBearTM previously approved these changes Mar 30, 2023
View reviewed changes
@sonarqubecloud
Copy link

[DH3 Frontend App] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[Energy Origin App] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@frontend-specialisten frontend-specialisten merged commit e4097bc into main Mar 31, 2023
@frontend-specialisten frontend-specialisten deleted the chore/update-nx-15-8 branch March 31, 2023 06:40
CodeReaper added a commit that referenced this pull request Mar 31, 2023
@CodeReaper
Merge branch 'main' into preview/extract-scope-from-token
7bc1f48 
* main:
  Nswag change to poco from record (#1605)
  Follow naming conventions for mutations (#1601)
  Update NX to latest version (15.8.9) (#1586)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzhavat dzhavat dzhavat approved these changes

@ManBearTM ManBearTM ManBearTM left review comments

@mimse mimse mimse left review comments

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frontend-specialisten @dzhavat @mimse @ManBearTM