Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to .NET8 and align code structure for Databricks #290

Merged
merged 11 commits into from
Mar 11, 2024
Merged

Bump to .NET8 and align code structure for Databricks #290

merged 11 commits into from
Mar 11, 2024

Conversation

Sondergaard
Copy link
Contributor

Description

This PR is a chore. It adds the following changes.

  • Bump to newest .NET8 framework
  • Add ConfigureAwait to async methods so that it is aligned with other projects
  • Utilise new language features for file-scope namespaces

Quality

  • Documentation is updated
  • Release notes are updated
  • Package version is updated
  • Public types and methods are documented
  • Tests are implemented and executed locally

@cla-bot cla-bot bot added the cla-signed label Mar 8, 2024
dstenroejl
dstenroejl reviewed Mar 11, 2024
View reviewed changes
Copy link
Contributor

@dstenroejl dstenroejl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioned a few suggestions. Not sure what to do with primary constructors.

source/Databricks/.editorconfig Outdated Show resolved Hide resolved
source/Databricks/.editorconfig Outdated Show resolved Hide resolved
source/Databricks/source/SqlStatementExecution/Formats/StronglyTypedApacheArrowFormat.cs Show resolved Hide resolved
source/Databricks/source/SqlStatementExecution/DatabricksSqlWarehouseQueryExecutor.cs Outdated Show resolved Hide resolved
source/Databricks/source/SqlStatementExecution/DatabricksSqlWarehouseQueryExecutor.cs Outdated Show resolved Hide resolved
@Sondergaard @dstenroejl
Add missing ConfigureAwait()
25d5d0a 
Co-authored-by: Dan Stenrøjl <51327761+dstenroejl@users.noreply.github.com>
dstenroejl
dstenroejl approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@dstenroejl dstenroejl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sondergaard Sondergaard merged commit 7c9cd10 into main Mar 11, 2024
20 checks passed
@Sondergaard Sondergaard deleted the sondergaard/configure-async-analyzers branch March 11, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstenroejl dstenroejl dstenroejl approved these changes

@FirestarJes FirestarJes Awaiting requested review from FirestarJes FirestarJes is a code owner

@jonasdmoeller jonasdmoeller Awaiting requested review from jonasdmoeller jonasdmoeller is a code owner

@HenrikSommer HenrikSommer Awaiting requested review from HenrikSommer HenrikSommer is a code owner

@RasmusGraabaek RasmusGraabaek Awaiting requested review from RasmusGraabaek RasmusGraabaek is a code owner

@michaelmajgaard michaelmajgaard Awaiting requested review from michaelmajgaard michaelmajgaard is a code owner

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sondergaard @dstenroejl