-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use deep equality in calledWith() to allow object/array arguments to match #38
Use deep equality in calledWith() to allow object/array arguments to match #38
Conversation
This general approach is fine with me. I don't think we really need to support globals anymore. Can you remove the usage line from the README that says you can still use globals? |
This shouldn't affect any behavior related to globals, though, right...? (Unless you want me to also remove the |
Line 1 won't work with globals |
@EndangeredMassa Ah, gotcha. Just removed that (as well as the |
@@ -170,5 +164,4 @@ bond = (obj, property) -> | |||
'restore': restore | |||
} | |||
|
|||
window.bond = bond if window? | |||
module.exports = bond if module?.exports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change this to the following?
module.exports = bond
Done. |
Use deep equality in calledWith() to allow object/array arguments to match
published in 2.0.0 |
Closes #37.
I started down the road of copying Underscore's
isEqual
functionality into this library, but found that it was a bit more convoluted than expected. (For example, the recursive functions called by_.isEqual
reference other Underscore functions.) I propose simply including Underscore in this project. You'll notice Underscore is not actually included in the built JS file; rather, Underscore is added topackage.json
andrequire
ed inbond.coffee
.Thoughts?