Send token in readJson if using raw github url as file-url #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EndBug
added
good first issue
|
Hey @christulin thanks for the PR! Your idea seems great! 🚀 |
EndBug
approved these changes
Oct 2, 2024
|
Heyy @christulin , sorry for the short (6 months 💀) wait. But I finally got around reviewing this one! |
|
@all-contributors please add @christulin for their code contribution |
|
I've put up a pull request to add @christulin! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drawing inspiration from this issue #204 in addition to this comment #147 (comment).
We'd like to be able to enter the GitHub Raw URL in the
file-urlbut have thetokenpassed in the auth header to allow access to private repositories. In this manner we could compare the version of a feature branch against the remote main branch, and not have to rely Regular Expressions against commit messages or changes to the base branch between commits etc..I agree the token shouldn't be passed to any website, so hopefully this
hostnamecheck suffices.Thanks for you consideration!
@EndBug I'm happy to also make docs changes if you see fit.