Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move failing tests to a separate workflow #3533

Merged
merged 17 commits into from
Jun 14, 2024
Merged

Move failing tests to a separate workflow #3533

merged 17 commits into from
Jun 14, 2024

Conversation

Nebyt
Copy link
Contributor

@Nebyt Nebyt commented Jun 7, 2024

No description provided.

@Nebyt Nebyt requested review from yushih and vsubhuman June 7, 2024 13:50
Nebyt
Nebyt commented Jun 7, 2024
View reviewed changes
Copy link
Contributor Author

@Nebyt Nebyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

Nebyt
Nebyt commented Jun 7, 2024
View reviewed changes
Copy link
Contributor Author

@Nebyt Nebyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@Nebyt Nebyt marked this pull request as ready for review June 7, 2024 20:01
vsubhuman
vsubhuman previously approved these changes Jun 10, 2024
View reviewed changes
Nebyt
Nebyt commented Jun 10, 2024
View reviewed changes
Copy link
Contributor Author

@Nebyt Nebyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@Nebyt Nebyt marked this pull request as draft June 10, 2024 08:17
Nebyt
Nebyt commented Jun 11, 2024
View reviewed changes
Copy link
Contributor Author

@Nebyt Nebyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/dapp-general

Nebyt
Nebyt commented Jun 11, 2024
View reviewed changes
Copy link
Contributor Author

@Nebyt Nebyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

Nebyt
Nebyt commented Jun 11, 2024
View reviewed changes
Copy link
Contributor Author

@Nebyt Nebyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ext-general

@Nebyt Nebyt marked this pull request as ready for review June 11, 2024 11:29
Nebyt and others added 2 commits June 11, 2024 14:33
@Nebyt
minor change
2e2bfbf
@vsubhuman
Merge remote-tracking branch 'origin/develop' into denis/yoext-1190/s…
9085887 
…eparate-failing-tests

# Conflicts:
#	packages/e2e-tests/test/19_changingFiat.test.js
vsubhuman
vsubhuman reviewed Jun 13, 2024
View reviewed changes
Copy link
Contributor

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@vsubhuman vsubhuman merged commit c6616e3 into develop Jun 14, 2024
7 checks passed
@vsubhuman vsubhuman deleted the denis/yoext-1190/separate-failing-tests branch June 14, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsubhuman vsubhuman vsubhuman left review comments

@yushih yushih Awaiting requested review from yushih

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nebyt @vsubhuman