Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): restore already restored wallet flow #3293

Merged

Conversation

nistadev
Copy link
Contributor

Screenshot

image

@nistadev nistadev changed the base branch from develop to release/4.23 September 18, 2023 20:19
@neuodev
Copy link
Contributor

neuodev commented Sep 18, 2023

[autoscirpt] Jira Ticket: The app crashes while restoring already restored wallet

@sonarqube-yoroi
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@neuodev neuodev changed the title Fix/yoext 790/restore already restored wallet flow fix(wallet): restore already restored wallet flow Sep 19, 2023
const isPrimary = type === 'primary';
return (
<Button
key={idx}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use label as the key.

Copy link
Contributor Author

@nistadev nistadev Sep 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 tho I think this component is commonly shared and refactored on the 5.0 version,let's keep an eye on that and let this one merge, for not blocking the 4.23 release!

@vsubhuman vsubhuman merged commit efc2c22 into release/4.23 Oct 4, 2023
17 of 23 checks passed
@vsubhuman vsubhuman deleted the fix/YOEXT-790/restore-already-restored-wallet-flow branch October 4, 2023 13:26
@vsubhuman vsubhuman mentioned this pull request Oct 4, 2023
24 tasks
@vsubhuman vsubhuman added this to the 4.23.0 milestone Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants