Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory link fix #632

Merged
merged 5 commits into from
Jul 6, 2023
Merged

Memory link fix #632

merged 5 commits into from
Jul 6, 2023

Conversation

lisicky
Copy link
Contributor

@lisicky lisicky commented Jul 5, 2023

No description provided.

@lisicky lisicky requested review from vsubhuman and twwu123 July 5, 2023 21:27
lisicky
lisicky commented Jul 5, 2023
View reviewed changes
Copy link
Contributor Author

@lisicky lisicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

This was linked to issues Jul 5, 2023
asmjs TransactionBuilder.min_fee() crash #631
Closed
Transaction.from_bytes() works for few times before breaking. #629
Closed
vsubhuman
vsubhuman approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lisicky , please let's make sure we try to push a proper fix in bindgen as soon as possible

@lisicky lisicky merged commit e80433e into master Jul 6, 2023
@lisicky lisicky deleted the evgenii/asmjs_memory branch July 6, 2023 07:49
@lisicky lisicky added this to the 11.5.0 milestone Jul 6, 2023
@lisicky lisicky mentioned this pull request Jul 7, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsubhuman vsubhuman vsubhuman approved these changes

@twwu123 twwu123 Awaiting requested review from twwu123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
11.5.0
Development

Successfully merging this pull request may close these issues.

asmjs TransactionBuilder.min_fee() crash Transaction.from_bytes() works for few times before breaking.
2 participants
@lisicky @vsubhuman