Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Witness builder #307

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Add Witness builder #307

wants to merge 17 commits into from

Conversation

SebastienGllmt
Copy link
Contributor

The problem with TransactionWitnessSet is that at the protocol level it should be a set, but at the CDDL level it's just a list. This means it's up to individual implementations to de-duplication which is not ideal.

This PR adds a TransactionWitnessSetBuilder which handles the deduplication for you. It's a first step to #37 and can also help with #273

@SebastienGllmt SebastienGllmt self-assigned this Dec 25, 2021
@SebastienGllmt SebastienGllmt mentioned this pull request Dec 25, 2021
Merged
rooooooooob
rooooooooob reviewed Dec 25, 2021
View reviewed changes
rust/src/plutus.rs Outdated Show resolved Hide resolved
@SebastienGllmt
Copy link
Contributor Author

SebastienGllmt commented Dec 25, 2021 •
edited
Loading

I went ahead and also added a RequiredWitnessSet so that the tx builder can pass information about which witnesses are required. I didn't hook it up to the tx builder since probably it would conflict with #273 too much

rooooooooob
rooooooooob reviewed Dec 28, 2021
View reviewed changes
rust/src/witness_builder.rs Show resolved Hide resolved
rust/src/witness_builder.rs Outdated Show resolved Hide resolved
@vsubhuman vsubhuman added this to the 10.0.0 milestone Feb 1, 2022
@vsubhuman
Merge remote-tracking branch 'origin/master' into witness-builder
fb79f26 
# Conflicts:
#	rust/pkg/cardano_serialization_lib.js.flow
#	rust/src/plutus.rs
@vsubhuman
flowgen update and merge fixes
ce41194
vsubhuman
vsubhuman reviewed Feb 6, 2022
View reviewed changes
Copy link
Contributor

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@vsubhuman vsubhuman modified the milestones: 10.0.0, 10.1.0 Feb 6, 2022
@vsubhuman vsubhuman requested a review from lisicky May 15, 2022 10:22
@vsubhuman vsubhuman modified the milestones: 10.1.0, 10.2.0 May 19, 2022
@vsubhuman
Merge remote-tracking branch 'origin/babbage' into witness-builder
b01faa8 
# Conflicts:
#	rust/src/crypto.rs
#	rust/src/lib.rs
#	rust/src/plutus.rs
#	rust/src/utils.rs
@vsubhuman vsubhuman changed the base branch from master to babbage July 9, 2022 19:31
@vsubhuman vsubhuman assigned vsubhuman and unassigned SebastienGllmt Jul 9, 2022
Base automatically changed from babbage to master July 27, 2022 13:15
@vsubhuman vsubhuman modified the milestones: 11.1.0, 11.2.0 Sep 12, 2022
@nicolasayotte
Copy link

This is important. Wen?

@lisicky lisicky modified the milestones: 11.2.0, 11.3.0 Dec 1, 2022
@lisicky lisicky removed this from the 11.3.0 milestone Jan 27, 2023
@jonathangenlambda
Copy link

Would it be possible to add functionality to combine two TransactionWitnessSet?

@stackchain stackchain modified the milestone: 11.4.0 Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rooooooooob rooooooooob rooooooooob left review comments

@vsubhuman vsubhuman vsubhuman left review comments

@lisicky lisicky Awaiting requested review from lisicky

At least 1 approving review is required to merge this pull request.

Assignees

@vsubhuman vsubhuman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SebastienGllmt @nicolasayotte @jonathangenlambda @rooooooooob @vsubhuman @lisicky @stackchain