Fixups for cargo-semver-checks
#4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The errors for gix are incredibly complicated, so this just adds some helper methods for determining if an error is due to a fetch (potentially) spuriously failing and _might_ succeed if retried
This allows downstream crates to access these important crate as reexports rather than needing to have a direct dependency themselves
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on a PR to resolve obi1kenobi/cargo-semver-checks#487, that crate was looking at the error for git operations to determine if they should be retried, which is....unfortunately way more complicated with gix. So this just adds helper methods on GitError to make that use case nicer.