Add concurrent helpers to Async/RemoteSparseIndex
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When requesting eg. several hundred crates, it's _generally_ more efficient to emit many concurrent requests, particularly on low core count machines
|
Note that in the case of rayon/crossbeam-channel, this only adds to dependencies if gix is not brought in, which feels reasonable rather than having additional feature flags. |
|
Does the multi-threaded Tokio executor measurably help? I'd expect the single-threaded one to be more than enough in this case. The multi-threaded runtime is more useful for high-load web servers. |
|
Uhh, didn't actually check that at all, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up during rustsec/rustsec#923, but it is often more efficient to send many concurrent requests with an async runtime than to use the blocking reqwest client with a threadpool eg rayon. This just adds
krateshelpers to request many crates concurrently for both the blocking and async implementations so that end users don't have to do it themselves.