Implement some float packing/unpacking instructions #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The new naming is better. Probably descriptive enough while still avoiding SSE-intrinsic-style acronym salad. The u32 types makes it clear enough that it's about packed values. |
hrydgard
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #707
Wasn't too hot on the GLSL/SPIR-V name of packHalf2x16, it's really confusing to me what the heck that means, so tried to go more explicit with the name - at least to me, f32x2_to_f16x2 is much more clear (and in line with the scalar f32_to_f16 version)
Left off f64 conversion insts for now, ark doesn't need them any time soon and they're weird (I think they're
transmute (u32, u32) <-> f64, not an actual bit-changing conversion?)