Infer the storage class for images/samplers/imagesamplers

[khyperia]

No description provided.

[XAMPPRocky]

LGTM! Do we also want to remove the uniform_constant attribute? Are there reasons to keep it?

[khyperia]

Not sure if it's used anywhere else, but if we do remove it, then we should also remove input/output/etc. (right now it's a consistent "include everything" thing, even things that aren't currently valid to place anywhere)

[XAMPPRocky]

Not sure if it's used anywhere else, but if we do remove it, then we should also remove input/output/etc. (right now it's a consistent "include everything" thing, even things that aren't currently valid to place anywhere)

Sound good to me. I'll file a separate issue for that.

Also the tests need formatting 🙃

[khyperia]

haha yeah, kinda sucks that cargo fmt doesn't catch the tests, have to run rustfmt tests/ui/**/*.rs, but whatever, at least a check is in CI~

[eddyb]

Not sure if it's used anywhere else, but if we do remove it, then we should also remove input/output/etc. (right now it's a consistent "include everything" thing, even things that aren't currently valid to place anywhere)

I've been told OpenGL uses UniformConstant the same way Vulkan uses PushConstant (which explains the name).

Removing input/output and function/private/generic should probably be done regardless.