Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new handling for SPIR-V targets #559

Merged
merged 3 commits into from
Apr 12, 2021
Merged

Add new handling for SPIR-V targets #559

merged 3 commits into from
Apr 12, 2021

Conversation

XAMPPRocky
Copy link
Member

This PR adds a target argument that you can set a different target environment from spirv-unknown-unknown with spirv-builder.

@XAMPPRocky XAMPPRocky requested review from eddyb and khyperia March 30, 2021 10:16
@XAMPPRocky XAMPPRocky requested review from fu5ha and VZout as code owners March 30, 2021 10:16
@XAMPPRocky XAMPPRocky removed request for fu5ha and VZout March 30, 2021 10:16
khyperia
khyperia approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@khyperia khyperia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending comment

@khyperia
Copy link
Contributor

Also, we should think about deriving spirv_version from the target triple in the compiler, instead of having it be a separate option

@XAMPPRocky

This comment has been minimized.

Sign in to view
@XAMPPRocky

This comment has been minimized.

Sign in to view
@khyperia

This comment has been minimized.

Sign in to view
@XAMPPRocky

This comment has been minimized.

Sign in to view
@XAMPPRocky XAMPPRocky force-pushed the spirv-builder-target branch from 7cfedea to 7f2825c Compare April 1, 2021 10:53
@XAMPPRocky XAMPPRocky force-pushed the spirv-builder-target branch 2 times, most recently from 821d779 to 3cdd8c6 Compare April 1, 2021 11:32
@XAMPPRocky XAMPPRocky force-pushed the spirv-builder-target branch from aadbcda to 9b0c601 Compare April 9, 2021 06:20
@XAMPPRocky XAMPPRocky force-pushed the spirv-builder-target branch from 078ef73 to 3b16f69 Compare April 9, 2021 08:21
@XAMPPRocky XAMPPRocky changed the title Add target argument to spirv-builder Add new handling for SPIR-V targets Apr 9, 2021
@XAMPPRocky XAMPPRocky requested a review from khyperia April 9, 2021 08:23
@XAMPPRocky XAMPPRocky force-pushed the spirv-builder-target branch from 3b16f69 to 45e9561 Compare April 9, 2021 08:25
@XAMPPRocky XAMPPRocky enabled auto-merge (squash) April 9, 2021 10:50
@XAMPPRocky XAMPPRocky force-pushed the spirv-builder-target branch from c8feb80 to f7567f0 Compare April 12, 2021 09:42
@XAMPPRocky
Fix disassembly test output
5e19ef9 
Previously these were compiled for vulkan environments, now they're
compiled to spv1.3 by default.
@XAMPPRocky XAMPPRocky merged commit b631178 into main Apr 12, 2021
@XAMPPRocky XAMPPRocky deleted the spirv-builder-target branch April 12, 2021 11:19
XAMPPRocky added a commit that referenced this pull request May 3, 2021
@XAMPPRocky
Add new handling for SPIR-V targets (#559)
0ca126d 
* Add new handling for SPIR-V targets

* Ensure target is always three components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VZout VZout VZout left review comments

@khyperia khyperia khyperia approved these changes

@eddyb eddyb Awaiting requested review from eddyb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XAMPPRocky @khyperia @VZout