Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multiple target environments #533

Merged
merged 4 commits into from
Mar 29, 2021
Merged

Add support for multiple target environments #533

merged 4 commits into from
Mar 29, 2021

Conversation

XAMPPRocky
Copy link
Member

This PR adds support for multiple target environments such as vulkan1.1, and fixes our tests to pass vulkan1.1 validation.

You can also now pass --target-env to compiletest to test SPIR-V environments.

cargo compiletest --target-env=vulkan1.1
# Or multiple
cargo compiletest --target-env=vulkan1.1,spv1.3

@XAMPPRocky XAMPPRocky requested review from eddyb and khyperia March 24, 2021 13:36
@XAMPPRocky XAMPPRocky force-pushed the env branch 2 times, most recently from 94ae624 to 3a619bf Compare March 29, 2021 06:02
eddyb
eddyb suggested changes Mar 29, 2021
View reviewed changes
tests/ui/storage_class/push_constant.rs Outdated Show resolved Hide resolved
tests/src/main.rs Show resolved Hide resolved
tests/src/main.rs Outdated Show resolved Hide resolved
@XAMPPRocky XAMPPRocky requested review from eddyb and khyperia March 29, 2021 06:23
eddyb
eddyb suggested changes Mar 29, 2021
View reviewed changes
tests/ui/storage_class/push_constant.rs Outdated Show resolved Hide resolved
crates/spirv-builder/src/test/basic.rs Show resolved Hide resolved
@XAMPPRocky XAMPPRocky mentioned this pull request Mar 29, 2021
Merged
@XAMPPRocky XAMPPRocky requested a review from eddyb March 29, 2021 08:03
@XAMPPRocky XAMPPRocky force-pushed the env branch 2 times, most recently from 0c8d8f9 to 370ef9d Compare March 29, 2021 10:36
@XAMPPRocky XAMPPRocky requested a review from eddyb March 29, 2021 16:05
@eddyb eddyb enabled auto-merge (rebase) March 29, 2021 16:11
auto-merge was automatically disabled March 29, 2021 16:41

Rebase failed

@XAMPPRocky XAMPPRocky merged commit 3a53968 into main Mar 29, 2021
@XAMPPRocky XAMPPRocky deleted the env branch March 29, 2021 16:43
XAMPPRocky added a commit that referenced this pull request May 3, 2021
@XAMPPRocky
Add support for multiple target environments (#533)
b1edac0 
* Add support for multiple target environments

* updates from code review

* Update lib.rs
@khyperia khyperia removed their request for review May 31, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khyperia khyperia khyperia left review comments

@eddyb eddyb eddyb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XAMPPRocky @eddyb @khyperia