Fix target_os = "none" parsing (#61)

EmbarkStudios · Jun 19, 2023 · ab22574 · ab22574
1 parent 960f370
commit ab22574
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/expr.rs b/src/expr.rs
@@ -79,7 +79,12 @@ impl TargetMatcher for targ::TargetInfo {
             },
             Family(fam) => self.families.contains(fam),
             HasAtomic(has_atomic) => self.has_atomics.contains(*has_atomic),
-            Os(os) => Some(os) == self.os.as_ref(),
+            Os(os) => match &self.os {
+                Some(self_os) => os == self_os,
+                // os = "none" means it should be matched against None. Note that this is different
+                // from "env" above.
+                None => os.as_str() == "none",
+            },
             PointerWidth(w) => *w == self.pointer_width,
             Vendor(ven) => match &self.vendor {
                 Some(v) => ven == v,

diff --git a/tests/eval.rs b/tests/eval.rs
@@ -251,6 +251,12 @@ fn complex() {
     // Should *not* match x86_64 windows or android
     assert!(!complex.eval(|pred| tg_match!(pred, windows_msvc)));
     assert!(!complex.eval(|pred| tg_match!(pred, android)));
+
+    // Ensure that target_os = "none" matches against Os == None.
+    let complex = Expression::parse(r#"all(target_os="none")"#).unwrap();
+    let armebv7r_none_eabi = Target::make("armebv7r-none-eabi");
+    assert!(!complex.eval(|pred| tg_match!(pred, linux_gnu)));
+    assert!(complex.eval(|pred| tg_match!(pred, armebv7r_none_eabi)));
 }
 
 #[test]