Skip to content

Commit

Permalink
bpo-37555: Add regression tests for mock ANY ordering issues
Browse files Browse the repository at this point in the history
Add regression tests for whether __eq__ is order agnostic on _Call and _CallList, which is useful for comparisons involving ANY, especially if the ANY comparison is to a class not defaulting __eq__ to NotImplemented.

Co-authored-by: Neal Finne <neal@nealfinne.com>
  • Loading branch information
ElizabethU and nealfinne committed Jul 15, 2019
1 parent ad99a9d commit 49c5310
Showing 1 changed file with 20 additions and 0 deletions.
20 changes: 20 additions & 0 deletions Lib/unittest/test/testmock/testhelpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,16 @@ def test_call_list(self):
kall = call(1).method(2)(3).foo.bar.baz(4)(5).__int__()
self.assertEqual(kall.call_list(), mock.mock_calls)

def test_call_list_with_any_comparison_order(self):
class Foo:
def __eq__(self, other): pass
def __ne__(self, other): pass

mock = MagicMock()
mock(Foo())

self.assertEqual(call(ANY).call_list(), mock.mock_calls)
self.assertEqual(mock.mock_calls, call(ANY).call_list())

def test_call_any(self):
self.assertEqual(call, ANY)
Expand All @@ -331,6 +341,16 @@ def test_call_any(self):
self.assertEqual(m.mock_calls, [ANY])
self.assertEqual([ANY], m.mock_calls)

def test_call_any_comparison_order(self):
class Foo:
def __eq__(self, other): pass
def __ne__(self, other): pass

m = MagicMock()
m(Foo())

self.assertEqual(m.mock_calls[0], call(ANY))
self.assertEqual(call(ANY), m.mock_calls[0])

def test_two_args_call(self):
args = _Call(((1, 2), {'a': 3}), two=True)
Expand Down

0 comments on commit 49c5310

Please sign in to comment.