(Test PR) Fix and simplify dependency groups and extras #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI checks look good. I'm closing this fork-internal PR. The branch should not be deleted, though, since I'll probably be reusing it for a PR on the upstream repository. |
This was referenced Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was so I could test some CI internally to my fork, and was never intended for merging. I made a separate PR on the upstream repository.
During this testing, I noticed that the release job ran even though it shouldn't, because this PR doesn't have the release label applied to it, and because this PR was closed without merging, either of which ought to have prevented that. See further testing of a possible solution to this in #4 and #5. See all release workflow runs in my fork here.