-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added timeout parameter #26
Conversation
@gsokoll the pull request will be ready for merging after we will agree on my comment on the underlying PR. After the merge, would you create also the PR in ROS1 branch? The contribution itself seems great, so it is important to have it both in ROS1 and ROS2 branches, I see. The code should be very similar, practically the same |
Sure. I have zero experience with ROS1, but I am happy to try. |
I have prepared a ROS1 version in a local clone. Once the underlying PR in IMU_QT is merged in, I will submit the PR for this repo. |
@gsokoll the PR in the underlying library is merged, so it is possible to proceed. |
Have cleaned up a few things I broke, and also submitted a matching PR for the ROS1 main branch. Both this and the ROS1 PR should be ok for a merge. |
Ok, try now. |
Per ROS2 test reports (#15), the node consistently failed with a " Sensor error: Timed out waiting for data, please check device connection and baudrate!" when the sensor polling interval matched the IMU output rate. Investigating the code, this was occuring because the read data function was not correctly checking for the absence of new data. Changes to the underlying witmotion IMU QT library have been made to address this issue (refer ElettraSciComp/witmotion_IMU_QT#7). This PR adds a timeout parameter to complement the changes made as part of the IMU QT PR.
The ROS2 launch mods (#25) have been included in this PR as I neede them during testing of the ROS2 code.