swap: exclude non-active swap in csvPassedCallback #316
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csv wait list is always added in AwaitPaymentOrCsvAction state but removed only after csvPassedCallback. csvPassedCallback always assumes an active swap, but in normal flows like preimage path, the swap might be complete, leaving no active swap at this point. This was not considered before, causing continuous errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
csv wait list is always added in
AwaitPaymentOrCsvActionstate but removed only after csvPassedCallback.csvPassedCallbackalways assumes an active swap, but in normal flows like preimage path, the swap might be complete,leaving no active swap at this point.
This was not considered before, causing continuous errors.
Previously, if a swap was completed through means other than the
CSV path, an error messagecsv passed callback err: swap does not exist.would occur unless the peerswap daemon was restarted.I have confirmed that this issue no longer occurs.