-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
probe payment as sanity check #260
Merged
Merged
Commits on Nov 23, 2023
-
policy: be able to set MinSwapAmountMsat
Change MinSwapAmountMsat to be set by policy.
Configuration menu - View commit details
-
Copy full SHA for da1fe17 - Browse repository at this point
Copy the full SHA da1fe17View commit details
Commits on Nov 24, 2023
-
Added test case to confirm that swap fails on StuckChannels. Allow pushAmt to be set during setup. Set min_swap_amount_msat to 1.
Configuration menu - View commit details
-
Copy full SHA for da8ecf3 - Browse repository at this point
Copy the full SHA da8ecf3View commit details -
swap: probe payment as sanity check
Replace sanity check with probe payment in SpendableMsat. ProbePayment trying to pay via a route with a random payment hash that the receiver doesn't have the preimage of. The receiver node aren't able to settle the payment. When the probe is successful, the receiver will return a incorrect_or_unknown_payment_details error to the sender. If the result of ProbePayment is assumed to be a payment failure, log the reason as known by ProbePayment
Configuration menu - View commit details
-
Copy full SHA for e5cbb6b - Browse repository at this point
Copy the full SHA e5cbb6bView commit details
Commits on Nov 26, 2023
-
testframework: verify that route is constructed
Route may not be built even when channel is active. Since this causes flaky test, Added to check route construction in advance.
Configuration menu - View commit details
-
Copy full SHA for 5c30387 - Browse repository at this point
Copy the full SHA 5c30387View commit details -
Restored sanity check of the maximum htlc limit. * To check max htlc more strictly than CLN's own limits. * To prevents a tiny bit of database bloat in situations where it is guaranteed to fail.
Configuration menu - View commit details
-
Copy full SHA for dbec5bb - Browse repository at this point
Copy the full SHA dbec5bbView commit details
Commits on Dec 19, 2023
-
cln: uses the exact channel to probe payment
To ensures that the invoice payment is probed via the direct channel to the peer.
Configuration menu - View commit details
-
Copy full SHA for a6af654 - Browse repository at this point
Copy the full SHA a6af654View commit details -
Configuration menu - View commit details
-
Copy full SHA for 52e2ff3 - Browse repository at this point
Copy the full SHA 52e2ff3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.