config: add function to detect allow-deprecated-apis=false in CLN config #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems easier to understand and maintain to deserialize the config into a tagged struct. This way, if we can not find the config, we wont panic and have a default bool (false) that we can check. Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a function
CheckForDeprecatedApiConfig()toclightning/config.goto check ifallow-deprecated-apisis set tofalsein the CLN config. This is because setting that option false turns off deprecated, but not yet fully removed, API fields that PeerSwap may rely on. If we detect it is setfalsethen we print a warning and exit the plugin to be safe.Resolves #228