Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Logs #203

Merged
merged 5 commits into from
Jul 12, 2023
Merged

Improve Logs #203

merged 5 commits into from
Jul 12, 2023

Conversation

nepet
Copy link
Contributor

@nepet nepet commented Jul 11, 2023

A collection of changes how we log. This includes:

  • Don't log redundant custom messages, we just log that we received the same message again
  • Don't log "message already exists" this is redundant information to the above
  • Remove blank lines when sending redundant messages.
  • Add information to the "tx does not have enough confirmations"

Please let me know if there are more blank lines or other improvements that would help you scan the logs.

@nepet
swap: Refactor out incoming message log
2589c32 
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
@nepet
swap: Add last message log map
3862a34 
We use this log to keep track of which incoming message types have
already been logged.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
@nepet
cln: Remove spammy log message
5a7963f 
We don't need to log on a "message already exists error" as we
already log if we receive a message that we already know.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
@nepet
msgs: Remove blank lines from log messages
cec1a86 
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
@nepet
txwatcher: Add more information to otherwise useless log message
17e9414 
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
@nepet nepet requested a review from wtogami July 11, 2023 15:07
wtogami
wtogami approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@wtogami wtogami left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK

@wtogami wtogami merged commit 8075b00 into ElementsProject:master Jul 12, 2023
6 checks passed
@wtogami wtogami mentioned this pull request Jul 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtogami wtogami wtogami approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nepet @wtogami