offers: don't send blinded path to neighbor for *invoices*. #8125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 6e4ff6a ("offers: add a blinded path if we have no advertized address") we were overzealous, and set blinded paths not just for offers and invoicerequests, but for invoices themselves. This has revealed various interop issues (which is great, but not good for our users!) so we should disable that. It also reduces the reliability of payments in general. Changelog-None: fixes previously overzealous addition Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
debug-xpay-blinded-path-more
branch
from
437d81e to
bf19b25
Compare
endothermicdev
merged commit 8f891ce
into
ElementsProject:master
36 of 40 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 6e4ff6a ("offers: add a blinded path if we have no advertized address") we were overzealous, and set blinded paths not just for offers and invoicerequests, but for invoices themselves.
This has revealed various interop issues (which is great, but not good for our users!) so we should disable that. It also reduces the reliability of payments in general.
Changelog-None: fixes previously overzealous addition
Fixes: #8119 (really!)