Aggressive Gossip Seeker #7768
Merged
Aggressive Gossip Seeker #7768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on gossip sync data from random network peers, listening to only 5 peers will not reliably catch all gossip traffic. For now, add extra redundancy.
endothermicdev
force-pushed
the
aggressive-seeker
branch
2 times, most recently
from
ad0bcf6 to
fbb20cd
Compare
This can help us backfill any missing gossip if our current peers haven't been the most reliable. Changelog-Changed: Gossipd requests a full sync from a random peer every hour.
This will be used to drop underperforming gossipers instead of choosing at random.
Previously they were chosen at random. We should instead prefer to strop streaming from the peer who has provided the least novel gossip.
This will allow all gossipers to be rotated in ~5 hours similar to how it operated with half as many gossip streaming peers.
endothermicdev
force-pushed
the
aggressive-seeker
branch
from
fbb20cd to
1b71451
Compare
in test_gossip_force_broadcast_channel_msgs now that the seeker is asking for periodic full gossip syncs.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Open for merging new PRs until the next PR freeze date is confirmed!
Checklist
The gossip seeker has been getting less reliable with nodes often failing to provide a full gossip sync when requested and/or miss gossip when streaming. This PR does several thing to address this:
Considering a blackbox test for gossip rotation, but it's probabilistic, which makes it more difficult to test reliably.